Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ' in documentation #490

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Conversation

LeeTeng2001
Copy link
Contributor

@LeeTeng2001 LeeTeng2001 commented Dec 26, 2022

Motivation

Fix typo in documentation

Modification

I've added a closing ' to the documentation

Who can help? @ them here!

Checklist

Before PR:

  • [x ] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [ x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [ x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ x] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [ x] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@LeoXing1996 LeoXing1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LeeTeng2001, thanks for your contribution. This modification looks good to me.

BTW, MMGeneration had merged into MMEditing dev-1.x, and no more new features will be supported in MMGeneration. So, we would like to encourage you to use MMEditing.

@LeoXing1996 LeoXing1996 merged commit f9f00fd into open-mmlab:master Dec 26, 2022
@OpenMMLab-Assistant001
Copy link

Hi @LeeTeng2001 !First of all, we want to express our gratitude for your significant PR in the MMGeneration . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution!❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants