Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Test commands of mim in CI #332

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

fangyixiao18
Copy link
Collaborator

@fangyixiao18 fangyixiao18 commented Jun 21, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Test search command of mim in CI to ensure the format of metafile is correct.
Refer to open-mmlab/mmsegmentation#1654

Modification

Add .github/workflows/test_mim.yml

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #332 (b22e890) into master (69033ac) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   72.46%   72.44%   -0.03%     
==========================================
  Files         120      120              
  Lines        4703     4703              
  Branches      757      757              
==========================================
- Hits         3408     3407       -1     
  Misses       1137     1137              
- Partials      158      159       +1     
Flag Coverage Δ
unittests 72.44% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/utils/misc.py 97.05% <0.00%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8629015...b22e890. Read the comment docs.

@Jiahao000 Jiahao000 merged commit 18543db into open-mmlab:master Jun 22, 2022
@fangyixiao18 fangyixiao18 deleted the test-mim-in-ci branch July 15, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants