Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmix/pmix112: Update to version 1.2.0 #2286

Merged
merged 3 commits into from
Jan 22, 2017
Merged

pmix/pmix112: Update to version 1.2.0 #2286

merged 3 commits into from
Jan 22, 2017

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Oct 24, 2016 •
edited
Loading

  • Updating the internal version of PMIx to the PMIx 1.2.0 release

@jjhursey jjhursey added this to the v2.1.0 milestone Oct 24, 2016
@jjhursey
Copy link
Member Author

Note that there is nothing to cherry-pick from OMPI master since OMPI master embeds the PMI master branch.

@artpol84
Copy link
Contributor

@karasevb, please verify that this is working well.

@rhc54
Copy link
Contributor

rhc54 commented Oct 24, 2016

FWIW: I have MTT running it now on my cluster - so far, so good. Will post results when done

@jjhursey
Copy link
Member Author

Using the internal version things are looking good. I'm looking into some include issue with the external component at the moment.

@rhc54
Copy link
Contributor

rhc54 commented Oct 24, 2016

No problems found with the internal version:

+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+
| Phase       | Section         | MPI Version | Duration | Pass | Fail | Time out | Skip | Detailed report                                                          |
+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+
| MPI Install | my installation | 2.0.2a1     | 00:01    | 1    |      |          |      | MPI_Install-my_installation-my_installation-2.0.2a1-my_installation.html |
| Test Build  | trivial         | 2.0.2a1     | 00:01    | 1    |      |          |      | Test_Build-trivial-my_installation-2.0.2a1-my_installation.html          |
| Test Build  | ibm             | 2.0.2a1     | 00:39    | 1    |      |          |      | Test_Build-ibm-my_installation-2.0.2a1-my_installation.html              |
| Test Build  | intel           | 2.0.2a1     | 01:16    | 1    |      |          |      | Test_Build-intel-my_installation-2.0.2a1-my_installation.html            |
| Test Build  | java            | 2.0.2a1     | 00:03    | 1    |      |          |      | Test_Build-java-my_installation-2.0.2a1-my_installation.html             |
| Test Build  | orte            | 2.0.2a1     | 00:00    | 1    |      |          |      | Test_Build-orte-my_installation-2.0.2a1-my_installation.html             |
| Test Build  | oshmem          | 2.0.2a1     | 00:24    | 1    |      |          |      | Test_Build-oshmem-my_installation-2.0.2a1-my_installation.html           |
| Test Run    | trivial         | 2.0.2a1     | 00:05    | 8    |      |          |      | Test_Run-trivial-my_installation-2.0.2a1-my_installation.html            |
| Test Run    | ibm             | 2.0.2a1     | 06:57    | 480  | 3    |          | 3    | Test_Run-ibm-my_installation-2.0.2a1-my_installation.html                |
| Test Run    | spawn           | 2.0.2a1     | 00:07    | 7    |      |          |      | Test_Run-spawn-my_installation-2.0.2a1-my_installation.html              |
| Test Run    | loopspawn       | 2.0.2a1     | 02:35    |      | 1    |          |      | Test_Run-loopspawn-my_installation-2.0.2a1-my_installation.html          |
| Test Run    | intel           | 2.0.2a1     | 14:36    | 474  |      |          | 4    | Test_Run-intel-my_installation-2.0.2a1-my_installation.html              |
| Test Run    | intel_skip      | 2.0.2a1     | 10:18    | 431  |      |          | 47   | Test_Run-intel_skip-my_installation-2.0.2a1-my_installation.html         |
| Test Run    | java            | 2.0.2a1     | 00:01    | 1    |      |          |      | Test_Run-java-my_installation-2.0.2a1-my_installation.html               |
| Test Run    | orte            | 2.0.2a1     | 00:38    | 19   |      |          |      | Test_Run-orte-my_installation-2.0.2a1-my_installation.html               |
| Test Run    | oshmem          | 2.0.2a1     | 17:20    | 255  | 43   | 8        |      | Test_Run-oshmem-my_installation-2.0.2a1-my_installation.html             |
+-------------+-----------------+-------------+----------+------+------+----------+------+--------------------------------------------------------------------------+

@karasevb
Copy link
Member

It works well. And checked with external.
👍

@jjhursey
Copy link
Member Author

PMIx 1.2.0rc1 is here (in case folks want to try it with the external component):

jsquyres
jsquyres previously requested changes Oct 25, 2016
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Signed-off-by line to this PR's commits.

@jjhursey jjhursey dismissed jsquyres’s stale review October 26, 2016 12:39

Commit message has been updated with sign-off

@jjhursey
Copy link
Member Author

bot:ibm:retest

@jjhursey jjhursey mentioned this pull request Nov 1, 2016
Closed
@jjhursey
Copy link
Member Author

I just updated this branch with the v1.2.0rc2:

Ralph Castain and others added 3 commits December 20, 2016 15:23
@jjhursey
Do not use "==" in configure "test" calls
e0bb3f8 
Thanks to Kevin Buckley for pointing it out

(cherry picked from commit 0b3f4c5)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey
pmix/config: Update configure logic to check versions
961c418 
 * This attempts to match the current state on OMPI `master`, however
   those commits do not cleanly cherry-pick over so we created a custom
   patch for the changes noted below:
   - open-mpi/ompi@9a5ef60
   - open-mpi/ompi@55923ea
   - open-mpi/ompi@7b115a9
   - open-mpi/ompi@12ecf97
   - open-mpi/ompi@639dbdb
   - open-mpi/ompi@af67f16

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey
pmix/pmix112: Update to release PMIx 1.2.0
abf7378 
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey
Copy link
Member Author

I just pushed an updated version that matches the PMIx v1.2.0 release.

@jjhursey jjhursey requested a review from rhc54 December 21, 2016 16:48
@jjhursey
Copy link
Member Author

@rhc54 If you have a chance can you review this branch?

rhc54
rhc54 approved these changes Jan 10, 2017
View reviewed changes
Copy link
Contributor

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine

@jjhursey
Copy link
Member Author

Per discussion on the OMPI teleconf: We might want to wait on pulling this in until we get the PMIx v1.2.1 point release. Alternatively, we could merge this in and I can create another PR for the PMIx v1.2.1 update. Whichever the RMs decide would be better.

@jsquyres
Copy link
Member

@jjhursey I think it doesn't matter because the end date is going to be the same in both cases, right? If that's correct, do whichever one is less work. 😄

@jjhursey
Copy link
Member Author

It's probably less work to just update this PR with an additional commit once PMIx v1.2.1 is released. I guess the only reason to merge it in sooner would be to get more MTT testing on it.

@jjhursey
Copy link
Member Author

Discussion on the OMPI Teleconf. Let's merge this in to get some MTT exposure. I'll open another PR once PMIx v1.2.1 is ready. PMIx v1.2.1 will be a bug fix release.

@hppritcha hppritcha merged commit 739923c into open-mpi:v2.x Jan 22, 2017
@jjhursey jjhursey deleted the topic/v2.x-pmix-1.2.0 branch February 2, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhc54 rhc54 rhc54 approved these changes

@jsquyres jsquyres jsquyres left review comments

Assignees

@rhc54 rhc54

@jjhursey jjhursey

@artpol84 artpol84

Labels
bug enhancement RM approved
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jjhursey @artpol84 @rhc54 @karasevb @jsquyres @hppritcha