Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osc/pt2pt: disable when THREAD_MULITPLE #5200

Merged

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented May 29, 2018

osc/pt2pt: disable osc/pt2pt with THREAD_MULTIPLE.

Per discussion at #2614 (comment), do not allow for selection of the OSC PT2PT when creating an MPI RMA window when THREAD_MULTIPLE is active. Print a helpful message and return a not-supported error.

Signed-off-by: Howard Pritchard howardp@lanl.gov
Signed-off-by: Jeff Squyres jsquyres@cisco.com

(cherry picked from commit d0ffd66)

This will be PR'ed to v3.0.x and v3.1.x when merged to master (and will naturally be included in v4.0.x because we haven't branched for it yet).

Fixes #2614.

@jsquyres jsquyres requested a review from hjelmn May 29, 2018 15:59
@jsquyres jsquyres changed the title osc/pt2pt: workaround for issue 2614 for v2.0.2 osc/pt2pt: disable when THREAD_MULITPLE May 29, 2018
Per discussion at
open-mpi#2614 (comment),
do not allow for selection of the OSC PT2PT when creating an MPI RMA
window when THREAD_MULTIPLE is active.  Print a helpful message and
return a not-supported error.

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>

(cherry picked from commit d0ffd66)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
@jsquyres jsquyres force-pushed the pr/disable-osc-pt2pt-for-thread-multiple branch from 66bdd3d to 5b7c866 Compare May 29, 2018 16:00
@jsquyres
Copy link
Member Author

@gpaulsen confirms that the 2 IBM CIs are falsely stuck -- they just failed to create a gist, and therefore didn't report their results back (thereby leaving the CI in a "pending" state). Geoff created a gist manually: https://gist.github.com/ibm-ompi/5f2d981dd58cb54a072be3fb81aa806c

Meaning: IBM CI actually did pass; the "pending" states here are just showing a failure to report back the results correctly.

Merging...

@jsquyres jsquyres merged commit 2e8ab41 into open-mpi:master May 29, 2018
@jsquyres jsquyres deleted the pr/disable-osc-pt2pt-for-thread-multiple branch May 29, 2018 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants