Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test suites for second half of PSP policies #133

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Add test suites for second half of PSP policies #133

merged 3 commits into from
Dec 16, 2021

Conversation

maxsmythe
Copy link
Contributor

Signed-off-by: Max Smythe smythe@google.com

willbeason
willbeason approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@willbeason willbeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test with "gator test ./..."?

@maxsmythe
Copy link
Contributor Author

yep!

@sozercan @shomron @ritazh LGTY?

@maxsmythe
Copy link
Contributor Author

We'll need to add metadata.name per #156

@maxsmythe
Add test suites for second half of PSP policies
71930ac 
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Add names to suites
aec606b 
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Copy link
Contributor Author

Added metadata.name to all pre-existing suites, still LGTY @julianKatz @willbeason ?

@willbeason
Copy link
Member

willbeason commented Dec 15, 2021 •
edited
Loading

Added metadata.name to all pre-existing suites, still LGTY @julianKatz @willbeason ?

My nit would be to use hyphens to separate words in metadata.name to make them more readable. Not a blocker though, still LGTM.

@julianKatz
Copy link
Contributor

Added metadata.name to all pre-existing suites, still LGTY @julianKatz @willbeason ?

LGTM

@maxsmythe maxsmythe merged commit 6e3d6b4 into open-policy-agent:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh approved these changes

@julianKatz julianKatz julianKatz approved these changes

@willbeason willbeason willbeason approved these changes

@shomron shomron Awaiting requested review from shomron

@sozercan sozercan Awaiting requested review from sozercan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxsmythe @willbeason @julianKatz @ritazh