Skip to content

Commit

Permalink
Make the controller-gen target non user-facing
Browse files Browse the repository at this point in the history
  • Loading branch information
julianKatz committed Nov 12, 2020
1 parent 81732ee commit d18de3d
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ deploy: patch-image manifests
kustomize build config/overlays/dev | kubectl apply -f -

# Generate manifests e.g. CRD, RBAC etc.
manifests: controller-gen
manifests: __controller-gen
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./apis/..." paths="./pkg/..." output:crd:artifacts:config=config/crd/bases
rm -rf manifest_staging
mkdir -p manifest_staging/deploy
Expand All @@ -160,7 +160,7 @@ lint:
golangci-lint -v run ./... --timeout 5m

# Generate code
generate: controller-gen target-template-source
generate: __controller-gen target-template-source
$(CONTROLLER_GEN) object:headerFile=./hack/boilerplate.go.txt paths="./apis/..." paths="./pkg/..."

# Docker Login
Expand Down Expand Up @@ -256,9 +256,7 @@ promote-staging-manifest:
uninstall:
kustomize build config/overlays/dev | kubectl delete -f -

# find or download controller-gen
# download controller-gen if necessary
controller-gen: __tooling-image
__controller-gen: __tooling-image
CONTROLLER_GEN=docker run -v $(shell pwd):/gatekeeper gatekeeper-tooling controller-gen

__tooling-image:
Expand Down

0 comments on commit d18de3d

Please sign in to comment.