Serve Helm repo #611
Merged
Serve Helm repo #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
maxsmythe
reviewed
May 5, 2020
ritazh
reviewed
May 14, 2020
| @@ -239,6 +239,8 @@ promote-staging-manifest: | |||
| @cp -r manifest_staging/deploy . | |||
| @rm -rf charts | |||
| @cp -r manifest_staging/charts . | |||
| @helm package ./charts/gatekeeper -d ./charts/gatekeeper | |||
There was a problem hiding this comment.
Won't the tgz files get wiped out by rm -rf charts
There was a problem hiding this comment.
it does, i mentioned Since it gets wiped out every release, we'll only be hosting latest chart in the description
There was a problem hiding this comment.
oh sorry I missed that. do we want to also keep the old charts?
sozercan
added a commit
to sozercan/gatekeeper
that referenced
this pull request
May 15, 2020
* Use "k" instead of "K" for mem parsing Signed-off-by: Robert Sheehy <rob.sheehy@workiva.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * update ci to build and release multi-architecture images (open-policy-agent#571) * update ci to build and release multi-architecture images Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update Makefile Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * update buildx tags for releases and use make env tag for dev Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * adding docker buildx functionality into CI Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update workflow.yaml reverting quotation Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Fix expected service account name (open-policy-agent#606) Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * add metrics doc (open-policy-agent#608) Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Upgrade to controller-runtime 0.6.0, client-go v0.18.2. Rebase dynamiccache fork accordingly (open-policy-agent#563) (open-policy-agent#601) * Upgrade to controller-runtime 0.6.0, client-go v0.18.2. Rebase dynamiccache fork accordingly (open-policy-agent#563) Signed-off-by: Oren Shomron <shomron@gmail.com> * Update vendor Signed-off-by: Oren Shomron <shomron@gmail.com> * Update controller-runtime README.md Signed-off-by: Oren Shomron <shomron@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update Seccomp PSP to work as expected Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update package name and template Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * fix cold cache problem by making a request to api-server Signed-off-by: Shravan Achar <shravan.achar91@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Rename tests Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * add dryrun e2e test (open-policy-agent#427) * add dryrun test Signed-off-by: Sertaç Özercan <sozercan@gmail.com> * update with dryrun then deny Signed-off-by: Sertaç Özercan <sozercan@gmail.com> * update Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * revert order Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * check generation Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * helper Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * add quotes Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Co-authored-by: Sertaç Özercan <sozercan@users.noreply.github.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update workflow.yaml Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * updating Makefile to execute test Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Fix empty resource name for logDenies (open-policy-agent#619) * Fix empty resource name for logDenies Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> * Check req name only for logDenies Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Split helm output into multiple files (open-policy-agent#595) * Split helm output into multiple files Signed-off-by: Max Smythe <smythe@google.com> * Fix lint issues Signed-off-by: Max Smythe <smythe@google.com> * Remove newline Signed-off-by: Max Smythe <smythe@google.com> * Make newlines explicit Signed-off-by: Max Smythe <smythe@google.com> * Add Helm README Signed-off-by: Max Smythe <smythe@google.com> * Forgot to regenerate manifest Signed-off-by: Max Smythe <smythe@google.com> * Also write the tail of the config Signed-off-by: Max Smythe <smythe@google.com> * Update version information at config source, regen configs Signed-off-by: Max Smythe <smythe@google.com> * Rename "helm" directory to "charts" Signed-off-by: Max Smythe <smythe@google.com> * Fix chart directory reference in chart README Signed-off-by: Max Smythe <smythe@google.com> * Add default chart value for `affinity` Signed-off-by: Max Smythe <smythe@google.com> * helm -> charts Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Fix bleed-through of watches from other registrars when calling ReplaceWatch() (open-policy-agent#620) Previously, when calling ReplaceWatch(), watches were added kinds originating from other registrars. This would trigger a sanity check in doAddWatch(): ``` // Sanity if !m[gvk].registrars[r] { return fmt.Errorf("registrar %s not in desired watch set", r.parentName) } ``` This commit fixes the logic in replaceWatches to correctly account for multiple registrars. Signed-off-by: Oren Shomron <shomron@gmail.com> Co-authored-by: Max Smythe <smythe@google.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * add helm repo generation (open-policy-agent#611) Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * adding test to release Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * test timeouts Co-authored-by: Robert Sheehy <rob.sheehy@workiva.com> Co-authored-by: Michael Fornaro <dreamappsoftware@gmail.com> Co-authored-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Co-authored-by: Oren Shomron <shomron@gmail.com> Co-authored-by: Emma McMillan <emma.mcmillan@microsoft.com> Co-authored-by: Shravan Achar <shravan.achar91@gmail.com> Co-authored-by: Sertaç Özercan <sozercan@users.noreply.github.com> Co-authored-by: Max Smythe <smythe@google.com>
sozercan
added a commit
that referenced
this pull request
Jun 3, 2020
* Use "k" instead of "K" for mem parsing Signed-off-by: Robert Sheehy <rob.sheehy@workiva.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * update ci to build and release multi-architecture images (#571) * update ci to build and release multi-architecture images Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update Makefile Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * update buildx tags for releases and use make env tag for dev Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * adding docker buildx functionality into CI Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update workflow.yaml reverting quotation Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Fix expected service account name (#606) Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * add metrics doc (#608) Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Upgrade to controller-runtime 0.6.0, client-go v0.18.2. Rebase dynamiccache fork accordingly (#563) (#601) * Upgrade to controller-runtime 0.6.0, client-go v0.18.2. Rebase dynamiccache fork accordingly (#563) Signed-off-by: Oren Shomron <shomron@gmail.com> * Update vendor Signed-off-by: Oren Shomron <shomron@gmail.com> * Update controller-runtime README.md Signed-off-by: Oren Shomron <shomron@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update Seccomp PSP to work as expected Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update package name and template Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * fix cold cache problem by making a request to api-server Signed-off-by: Shravan Achar <shravan.achar91@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Rename tests Signed-off-by: Emma McMillan <emma.mcmillan@microsoft.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * add dryrun e2e test (#427) * add dryrun test Signed-off-by: Sertaç Özercan <sozercan@gmail.com> * update with dryrun then deny Signed-off-by: Sertaç Özercan <sozercan@gmail.com> * update Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * revert order Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * check generation Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * helper Signed-off-by: Sertac Ozercan <sozercan@gmail.com> * add quotes Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Co-authored-by: Sertaç Özercan <sozercan@users.noreply.github.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Update workflow.yaml Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * updating Makefile to execute test Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Fix empty resource name for logDenies (#619) * Fix empty resource name for logDenies Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> * Check req name only for logDenies Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Split helm output into multiple files (#595) * Split helm output into multiple files Signed-off-by: Max Smythe <smythe@google.com> * Fix lint issues Signed-off-by: Max Smythe <smythe@google.com> * Remove newline Signed-off-by: Max Smythe <smythe@google.com> * Make newlines explicit Signed-off-by: Max Smythe <smythe@google.com> * Add Helm README Signed-off-by: Max Smythe <smythe@google.com> * Forgot to regenerate manifest Signed-off-by: Max Smythe <smythe@google.com> * Also write the tail of the config Signed-off-by: Max Smythe <smythe@google.com> * Update version information at config source, regen configs Signed-off-by: Max Smythe <smythe@google.com> * Rename "helm" directory to "charts" Signed-off-by: Max Smythe <smythe@google.com> * Fix chart directory reference in chart README Signed-off-by: Max Smythe <smythe@google.com> * Add default chart value for `affinity` Signed-off-by: Max Smythe <smythe@google.com> * helm -> charts Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * Fix bleed-through of watches from other registrars when calling ReplaceWatch() (#620) Previously, when calling ReplaceWatch(), watches were added kinds originating from other registrars. This would trigger a sanity check in doAddWatch(): ``` // Sanity if !m[gvk].registrars[r] { return fmt.Errorf("registrar %s not in desired watch set", r.parentName) } ``` This commit fixes the logic in replaceWatches to correctly account for multiple registrars. Signed-off-by: Oren Shomron <shomron@gmail.com> Co-authored-by: Max Smythe <smythe@google.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * add helm repo generation (#611) Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * adding test to release Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * adding missing make cli call Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * run setup buildx for all jobs that require buildx functionality Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * adding BUILDPLATFORM arg Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * update workflow to remove redundant action Signed-off-by: Michael Fornaro <20387402+xUnholy@users.noreply.github.com> * push dev tag Signed-off-by: Sertac Ozercan <sozercan@gmail.com> Co-authored-by: Robert Sheehy <rob.sheehy@workiva.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Co-authored-by: Oren Shomron <shomron@gmail.com> Co-authored-by: Emma McMillan <emma.mcmillan@microsoft.com> Co-authored-by: Shravan Achar <shravan.achar91@gmail.com> Co-authored-by: Sertaç Özercan <sozercan@users.noreply.github.com> Co-authored-by: Max Smythe <smythe@google.com> Co-authored-by: Sertac Ozercan <sozercan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an helm repo hosted inside the repo (can be added to Helm using
helm repo add https://raw.githubusercontent.com/open-policy-agent/gatekeeper/master/chart/gatekeeper-operator/)Since it gets wiped out every release, we'll only be hosting latest chart
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #450