-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify resource limits for audit and controller pod separately using helm values #874
Conversation
c837c4c
to
672be21
Compare
Thanks for the submission! Can you sign the DCO (the link to do so is in the failed DCO check above). Also, in order to prevent this change from being clobbered the next time we generate a config, you'll need to update these three bits of code:
gatekeeper/cmd/build/helmify/replacements.go Lines 4 to 5 in 2cbba72
@sozercan this change in the schema of the values fields for Helm strikes me as a breaking change from the previous chart. Is that an issue? |
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 43.56% 43.34% -0.23%
==========================================
Files 47 47
Lines 3170 3170
==========================================
- Hits 1381 1374 -7
- Misses 1594 1598 +4
- Partials 195 198 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
4bca484
to
a2986ac
Compare
Looks like linting is failing with this error:
should clean up that file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll leave it to @sozercan to weigh in on the backwards compatibility question.
charts/gatekeeper/templates/gatekeeper-controller-manager-deployment.yaml
Outdated
Show resolved
Hide resolved
@RnkeZ can you run |
94740a7
to
9da6baa
Compare
Signed-off-by: Matej Kern <matej.kern@gmail.com> Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@gmail.com> Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@gmail.com> Signed-off-by: Matej Kern <matej.kern@infobip.com>
Ran make manifests Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One thing to note is that it looks like the docs in the README are missing these changes: https://github.com/open-policy-agent/gatekeeper/tree/master/charts/gatekeeper If I can get around to it, I'll submit a PR |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Closes #869
Special notes for your reviewer: