Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify resource limits for audit and controller pod separately using helm values #874

Merged
merged 8 commits into from
Oct 17, 2020

Conversation

RnkeZ
Copy link
Contributor

@RnkeZ RnkeZ commented Oct 7, 2020

What this PR does / why we need it:

  • Seperates resources value in values.yaml for audit and controller-manager deployment

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Closes #869

Special notes for your reviewer:

@RnkeZ RnkeZ changed the title Specify resource limits for audit and controller pod separately using helm values #869 Specify resource limits for audit and controller pod separately using helm values Oct 7, 2020
@RnkeZ RnkeZ force-pushed the master branch 3 times, most recently from c837c4c to 672be21 Compare October 7, 2020 15:04
@maxsmythe
Copy link
Contributor

Thanks for the submission!

Can you sign the DCO (the link to do so is in the failed DCO check above).

Also, in order to prevent this change from being clobbered the next time we generate a config, you'll need to update these three bits of code:

resources: HELMSUBST_DEPLOYMENT_CONTAINER_RESOURCES

resources: HELMSUBST_DEPLOYMENT_CONTAINER_RESOURCES

"HELMSUBST_DEPLOYMENT_CONTAINER_RESOURCES": `
{{ toYaml .Values.resources | indent 10 }}`,

@sozercan this change in the schema of the values fields for Helm strikes me as a breaking change from the previous chart. Is that an issue?

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #874 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   43.56%   43.34%   -0.23%     
==========================================
  Files          47       47              
  Lines        3170     3170              
==========================================
- Hits         1381     1374       -7     
- Misses       1594     1598       +4     
- Partials      195      198       +3     
Flag Coverage Δ
#unittests 43.34% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 52.76% <0.00%> (-2.94%) ⬇️
pkg/readiness/object_tracker.go 79.14% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 469f747...9637c10. Read the comment docs.

@RnkeZ RnkeZ force-pushed the master branch 4 times, most recently from 4bca484 to a2986ac Compare October 8, 2020 07:34
@maxsmythe
Copy link
Contributor

Looks like linting is failing with this error:

cmd/build/helmify/replacements.go:7: File is not `gofmt`-ed with `-s` (gofmt)

goimports -w cmd/build/helmify/replacements.go

should clean up that file

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll leave it to @sozercan to weigh in on the backwards compatibility question.

@sozercan
Copy link
Member

sozercan commented Oct 9, 2020

@RnkeZ can you run make manifests, it'll generate changes in manifests_staging/charts and commit those

@RnkeZ RnkeZ force-pushed the master branch 5 times, most recently from 94740a7 to 9da6baa Compare October 9, 2020 22:40
Signed-off-by: Matej Kern <matej.kern@gmail.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@gmail.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@gmail.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Ran make manifests

Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
Signed-off-by: Matej Kern <matej.kern@infobip.com>
@RnkeZ RnkeZ requested a review from sozercan October 14, 2020 06:39
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 02f2af9 into open-policy-agent:master Oct 17, 2020
mmirecki pushed a commit to mmirecki/gatekeeper that referenced this pull request Nov 10, 2020
@mveitas
Copy link
Contributor

mveitas commented Feb 1, 2021

One thing to note is that it looks like the docs in the README are missing these changes: https://github.com/open-policy-agent/gatekeeper/tree/master/charts/gatekeeper

If I can get around to it, I'll submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify resource limits for audit and controller pod separately using helm values
5 participants