Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers should be maintainers #184

Merged
merged 3 commits into from
Sep 20, 2019
Merged

maintainers should be maintainers #184

merged 3 commits into from
Sep 20, 2019

Conversation

SergeyKanzhelev
Copy link
Member

Fixes #49 #84

bhs
bhs reviewed Sep 19, 2019
View reviewed changes
Copy link
Contributor

@bhs bhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a little confusion about point 2.

docs/how-to-configure-new-repository.md Outdated Show resolved Hide resolved
docs/how-to-configure-new-repository.md Outdated Show resolved Hide resolved
bhs
bhs approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@bhs bhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the minor rewording I suggested for clarity.

@SergeyKanzhelev SergeyKanzhelev merged commit a4708cb into open-telemetry:master Sep 20, 2019
@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/maintainersShouldBeMaintainers branch September 20, 2019 00:13
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Oct 24, 2019
Closed
dyladan added a commit to dyladan/community that referenced this pull request Feb 17, 2022
@dyladan
Give maintainers admin permissions
ec5c413 
Reverts a change made in open-telemetry#184 which restricted maintainers from admin to
maintain permission.
@dyladan dyladan mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhs bhs bhs approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@sarahnovotny sarahnovotny Awaiting requested review from sarahnovotny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo configuration: repo-approvers team maintainers
4 participants
@SergeyKanzhelev @bogdandrutu @bhs @yurishkuro