Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify maintainer role in github teams #2196

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Clarify maintainer role in github teams #2196

merged 4 commits into from
Jul 11, 2024

Conversation

trask
Copy link
Member

@trask trask commented Jul 8, 2024

svrnm
svrnm reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We might want to review all the teams if they follow that structure or if any need fixing

@danielgblanco
Copy link
Contributor

Should we merge this and then go ahead and make sure all teams are setup like that? I think needs a TC member to do it.

@tsloughter
Copy link
Member

What @danielgblanco said. For example, I don't have permission to add maintainers to erlang-contrib-maintainers

@trask
Copy link
Member Author

trask commented Jul 10, 2024

Should we merge this and then go ahead and make sure all teams are setup like that? I think needs a TC member to do it.

I created #2205

@trask
Copy link
Member Author

trask commented Jul 10, 2024

I don't have permission to add maintainers to erlang-contrib-maintainers

@tsloughter you should have permission now

@arminru arminru merged commit 08365e3 into open-telemetry:main Jul 11, 2024
4 checks passed
@trask trask deleted the clarify-maintainer-role-in-github-teams branch July 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@svrnm svrnm svrnm approved these changes

@danielgblanco danielgblanco danielgblanco approved these changes

@arminru arminru arminru approved these changes

@alolita alolita Awaiting requested review from alolita alolita is a code owner

@austinlparker austinlparker Awaiting requested review from austinlparker austinlparker is a code owner

@dyladan dyladan Awaiting requested review from dyladan dyladan is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@mtwo mtwo Awaiting requested review from mtwo mtwo is a code owner

@tedsuo tedsuo Awaiting requested review from tedsuo tedsuo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@trask @danielgblanco @tsloughter @carlosalberto @svrnm @arminru