-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove and add new specs approvers #299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bogdandrutu
commented
Feb 11, 2020
- Remove @songy23 as he is no longer active in this project;
- Remove @AloisReitbauer as he is not active
- Add @arminru to the specs approver list - @arminru had more than 30 PRs reviewed and is active since July, 2019.
* Remove @songy23 as he is no longer active in this project; * Remove @AloisReitbauer as he is not active * Add @arminru to the specs approver list - @arminru had more than 30 PRs reviewed and is active since July, 2019.
bogdandrutu
requested review from
bhs,
ccaraman,
lizthegrey,
mtwo,
sarahnovotny,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
February 11, 2020 20:59
Does this have the consensus of @open-telemetry/technical-committee? |
SergeyKanzhelev
approved these changes
Feb 11, 2020
@yurishkuro and @carlosalberto please approve this PR |
songy23
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for removing myself :)
carlosalberto
approved these changes
Feb 12, 2020
@lizthegrey we need only @yurishkuro to approve this (@arminru +1 the PR, so that is good). |
yurishkuro
approved these changes
Feb 13, 2020
bogdandrutu
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Feb 13, 2020
bogdandrutu
added a commit
to open-telemetry/opentelemetry-proto
that referenced
this pull request
Feb 13, 2020
bogdandrutu
added a commit
to open-telemetry/oteps
that referenced
this pull request
Feb 13, 2020
bogdandrutu
added a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Feb 13, 2020
bogdandrutu
added a commit
to open-telemetry/oteps
that referenced
this pull request
Feb 13, 2020
bogdandrutu
added a commit
to open-telemetry/opentelemetry-proto
that referenced
this pull request
Feb 13, 2020
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
jsuereth
pushed a commit
to jsuereth/otel-semconv-test
that referenced
this pull request
Apr 19, 2023
jsuereth
pushed a commit
to open-telemetry/semantic-conventions
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.