No need for Admins group #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the requirement to make Admins group an admin of every repository. Org owners has enough permissions without this so this will remove an extra synchronization requirements.
SergeyKanzhelev
requested review from
bhs,
bogdandrutu,
ccaraman,
lizthegrey,
mtwo,
sarahnovotny,
tedsuo and
yurishkuro
as code owners
|
iirc the GC is in admins group but not org owners group? |
|
@lizthegrey the problem with having this Admins with GC members is that any GC review counts as "approver" which should not be the case. Maybe making GC members owners of the org should be discussed separately. |
|
@lizthegrey I think the best thing to do is to create a special group for GC that has control over community repo. There is nothing in GC charter that requires admin priviledges on repositories, I think this Admin group is a leftover from the time we decided to remove GC members from GitHub org owners list. |
bogdandrutu
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the requirement to make Admins group an admin of every repository. Org owners has enough permissions without this so this will remove an extra synchronization requirements.