access for triagers for project boards #542
Conversation
SergeyKanzhelev
requested review from
bhs,
bogdandrutu,
ccaraman,
lizthegrey,
mtwo,
sarahnovotny,
tedsuo and
yurishkuro
as code owners
|
Also created ticket with GitHub asking why Write permissions are needed https://support.github.com/ticket/personal/0/872841 |
| have access to the Project Boards. Note, by not adding members of `foo-triagers` to | ||
| CODEOWNERS file, repository restricts triagers from counting a triagers approvals for | ||
| PRs. See the [Policies](#policies) section that suggest to ensure that `Require | ||
| review from Code Owners` is checked. |
There was a problem hiding this comment.
I think their approvals will still count for the minimum number of required approvals (by members with write access) and the code owner check will pass even if only one single code owner has approved.
There was a problem hiding this comment.
yes, it still will be green. But at least some level of distinction between two roles may give some confidence to maintainers. Do you think some rewording is needed here? Or an additional note?
I hope that GitHub can change this =)
There was a problem hiding this comment.
I just wanted to point this out in case it was missed but if there's no way to work around this restriction I think it's fine.
Based on this conversation: #525 (comment)