update dotnet-autoinstrumentation role link #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change the link pointed to the top level readme which did not contain the community roles as indicated. Now the link points to the correct location where information can be found about membership and roles.
sharrmander
requested review from
alolita,
bhs,
bogdandrutu,
ccaraman,
dyladan,
lizthegrey,
mtwo,
sarahnovotny,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
nrcventura
reviewed
Oct 14, 2021
community-members.md
Outdated
| @@ -87,7 +87,7 @@ The [list of active members](https://github.com/open-telemetry/opentelemetry-dot | |||
|
|
|||
| Repo: [open-telemetry/opentelemetry-dotnet-instrumentation](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation). | |||
|
|
|||
| The [list of active members](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation#community-roles) (both "approvers" and "maintainers") can be found in the [README.md](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/master/README.md#community-roles) file in the [repo](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation). | |||
| The [list of active members](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation#community-roles) (both "approvers" and "maintainers") can be found in the [README.md](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/tree/main/docs#community-roles) file in the [repo](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation). | |||
There was a problem hiding this comment.
Should we also clarify that the README is under the docs folder in the repo?
There was a problem hiding this comment.
@nrcventura I don't know if we need to clarify that here; but I do think it would be helpful to specify that info in this place which would have helped me when I went searching for it: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation#readme
There was a problem hiding this comment.
This feedback is addressed in open-telemetry/opentelemetry-dotnet-instrumentation#246.
Also updated the preceding link to point to the accurate place
nrcventura
approved these changes
Oct 14, 2021
SergeyKanzhelev
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the link pointed to the top level readme which did not contain the community roles as indicated. Now the link points to the correct location where information can be found about membership and roles.