Add a process for becoming a maintainer #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
alolita,
bhs,
bogdandrutu,
jpkrohling,
lizthegrey,
mtwo,
tedsuo and
yurishkuro
as code owners
jpkrohling
reviewed
Jan 25, 2022
yurishkuro
reviewed
Jan 25, 2022
bhs
reviewed
Jan 25, 2022
jpkrohling
approved these changes
Jan 26, 2022
yurishkuro
approved these changes
Jan 26, 2022
tigrannajaryan
approved these changes
Jan 26, 2022
SergeyKanzhelev
approved these changes
Jan 26, 2022
|
I think i've addressed all comments. If I haven't gotten any objections I'll merge this monday morning. |
|
@bhs you're the only person who made a comment but has not yet approved. Want to give it one last look before merge? |
cijothomas
approved these changes
Jan 31, 2022
MrAlias
approved these changes
Jan 31, 2022
Aneurysm9
reviewed
Jan 31, 2022
community-membership.md
Outdated
Comment on lines
228
to
233
| is opened, and ends when the pull request is merged. The pull request may be | ||
| merged when the following conditions are met: | ||
|
|
||
| - The person being nominated has accepted the nomination by approving the pull request | ||
| - All maintainers have approved the pull request OR a majority of maintainers | ||
| have approved the pull request and no maintainer has objected by requesting changes on the pull request |
There was a problem hiding this comment.
Other comments have mentioned a five day period for the case where there is not unanimity. I do not see any language here regarding that.
There was a problem hiding this comment.
You're right. Added 3e03571
bogdandrutu
approved these changes
Jan 31, 2022
carlosalberto
approved these changes
Jan 31, 2022
Aneurysm9
approved these changes
Jan 31, 2022
mtwo
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed last week, here is a draft of a process for electing new SIG maintainers.