swap sqlserver drivers: denisenkom/go-mssqldb -> microsoft/go-mssqldb

[cwegener]

Component(s)

receiver/sqlquery

Describe the issue you're reporting

Round about the same time as the sqlqueryreceiver was created in 2022, Microsoft has created an official fork of https://github.com/denisenkom/go-mssqldb at https://github.com/microsoft/go-mssqldb in agreement with the original project maintainers denisenkom/go-mssqldb#729

Since then, there have been plenty of fixes and enhancement delivered under the new Microsoft umbrella and 3 official versioned releases.

And the original project is receiving the minimum maintenance effort.

From the above it seems to me that the otel collector should adopt the new fork of go-mssqldb in the sqlqueryreceiver.

[github-actions]

Pinging code owners:

• receiver/sqlquery: @dmitryax @pmcollins

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[dmitryax]

Sounds reasonable to me. @cwegener do you have a chance to help with this?

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• issue: Github issue template generation code needs this to generate the corresponding labels.
• receiver/sqlquery: @dmitryax @pmcollins

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[cwegener]

Right. Looks like I better jump through all the hoops to get this out ...

Questions:

1. Would this change be considered a 'behaviour change' in the eyes of the Contributing doc? https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#refactoring-work

--- a/upstream/receiver/sqlqueryreceiver/db_client.go
+++ b/upstream/receiver/sqlqueryreceiver/db_client.go
@@ -8,9 +8,10 @@ import (

        // register db drivers
        _ "github.com/SAP/go-hdb/driver"
-       _ "github.com/denisenkom/go-mssqldb"
        _ "github.com/go-sql-driver/mysql"
        _ "github.com/lib/pq"
+       _ "github.com/microsoft/go-mssqldb"
+       _ "github.com/microsoft/go-mssqldb/integratedauth/krb5"
        _ "github.com/sijms/go-ora/v2"
        _ "github.com/snowflakedb/gosnowflake"
        "go.uber.org/multierr"

I think it might be possible to split out the krb5 addition into a separate change, but then the swap from the old to the new driver could be considered broken ... I'll have to test out if the new MS driver works without the krb5 module ....

[andrzej-stencel]

Would this change be considered a 'behaviour change' in the eyes of the Contributing doc? https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#refactoring-work

I wouldn't sweat over it and would just add this new dependency "github.com/microsoft/go-mssqldb/integratedauth/krb5" if there's a chance that not adding it could break existing functionality.

[cwegener]

I'll just need to write up a CHANGELOG entry and then I'm good to go I think. I'll send through the patch via GH PR soon.

[andrzej-stencel]

Resolved in #29694