signalfxreceiver: allow multiple Start() calls #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
sfxreceivermultiplestarts
branch
from
69a6b04
to
18bdfbf
Compare
rmfitzpatrick
force-pushed
the
sfxreceivermultiplestarts
branch
from
18bdfbf
to
679bd7f
Compare
dmitryax
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug - With open-telemetry/opentelemetry-collector@b05c0f3 using the signalfx receiver in multiple pipelines causes a port conflict by trying to recreate an existing server. These changes ensure subsequent
Start()calls are noops.Testing: Updated existing test with repeated Start invocation.
Documentation: Changelog update