Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/elasticsearch]: add scraping metrics on cluster level #16346

Merged

Conversation

aboguszewski-sumo
Copy link
Member

@aboguszewski-sumo aboguszewski-sumo commented Nov 17, 2022

Description:
The receiver now scrapes cluster-level metrics from /_cluster/stats endpoint.
There were already some metrics sent with elasticsearch.cluster.name resource attribute, but they used different endpoint (/_cluster/health). I added the newly emitted metrics to the same resource.

Link to tracking Issue: #14635

Testing:
unit, integration

Documentation:
mdatagen

@aboguszewski-sumo
Copy link
Member Author

@djaglowski could this get reviewed soon?

@runforesight
Copy link

runforesight bot commented Dec 1, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 32 minutes 28 seconds compared to main branch avg(32 minutes 32 seconds).
View More Details

✅  build-and-test workflow has finished in 1 hour 1 minute 44 seconds (⚠️ 6 minutes 54 seconds more than main branch avg.) and finished at 1st Dec, 2022.


Job Failed Steps Tests
integration-tests -     🔗  ✅ 59  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest-matrix (1.18, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.18, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.18, processor) -     🔗  N/A See Details
unittest-matrix (1.18, exporter) -     🔗  N/A See Details
unittest-matrix (1.18, extension) -     🔗  N/A See Details
unittest-matrix (1.18, internal) -     🔗  N/A See Details
unittest-matrix (1.18, other) -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@djaglowski djaglowski merged commit 5f480be into open-telemetry:main Dec 5, 2022
@aboguszewski-sumo aboguszewski-sumo deleted the add-cluster-level-metrics branch December 5, 2022 14:15
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…-telemetry#16346)

* feat: add support for scraping cluster stats by the client
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants