[extension/encoding/jsonlogencoding] add new extension for JSON codec #27484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2023 15:51
|
@MovieStoreGuy @atoulme @dmitryax I would appreciate your review as well. |
added 2 commits
October 9, 2023 16:14
VihasMakwana
force-pushed
the
json-encoding-extension
branch
3 times, most recently
from
2296035
to
45fd9e9
Compare
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
45fd9e9
to
efacd14
Compare
|
@MovieStoreGuy for some reasons I cant update CODEOWNERS (maybe because I'm not member yet?). |
That's true. I suggest you to apply for membership given that you contributed enough already. Find two sponsors (at least one of them should not be from Splunk) and submit a PR similar to open-telemetry/community#1714. I'm happy to be one of the sponsors |
|
@atoulme you might be also interested to be a code owner? |
dmitryax
reviewed
Oct 10, 2023
|
I can be codeowner. |
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
98648de
to
5258e36
Compare
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
306b6b1
to
68226d3
Compare
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
68226d3
to
494c739
Compare
|
@dmitryax @astencel-sumo can you review this one? |
|
PTAL at the failing tests? |
dmitryax
reviewed
Oct 18, 2023
dmitryax
reviewed
Oct 18, 2023
VihasMakwana
force-pushed
the
json-encoding-extension
branch
2 times, most recently
from
6feb90d
to
b3c8fbf
Compare
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
b3c8fbf
to
d698e66
Compare
VihasMakwana
changed the title
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
d698e66
to
668eee3
Compare
VihasMakwana
force-pushed
the
json-encoding-extension
branch
from
668eee3
to
e34fcdf
Compare
yeah, running |
dmitryax
approved these changes
Oct 19, 2023
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Oct 20, 2023
…open-telemetry#27484) **Description:** Create a new extension for JSON. This will be used in pulsarreceiver/kafkareceiver to populate the log record's map from the raw body. **Link to tracking Issue:** [6272](https://github.com/open-telemetry/opentelemetry-collector/issues/6272) --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
…open-telemetry#27484) **Description:** Create a new extension for JSON. This will be used in pulsarreceiver/kafkareceiver to populate the log record's map from the raw body. **Link to tracking Issue:** [6272](https://github.com/open-telemetry/opentelemetry-collector/issues/6272) --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…open-telemetry#27484) **Description:** Create a new extension for JSON. This will be used in pulsarreceiver/kafkareceiver to populate the log record's map from the raw body. **Link to tracking Issue:** [6272](https://github.com/open-telemetry/opentelemetry-collector/issues/6272) --------- Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Create a new extension for JSON. This will be used in pulsarreceiver/kafkareceiver to populate the log record's map from the raw body.
Link to tracking Issue: 6272
Testing: Relevant cases added