Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/pdatatest] Ignore trace ID for ptracetest #27829

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[pkg/pdatatest] Ignore trace ID for ptracetest #27829

merged 1 commit into from
Oct 19, 2023

Conversation

sakulali
Copy link
Contributor

Description:
Support ignore trace ID in span comparisons for ptracetest.

Link to tracking Issue:
#27687

Testing:
make chlog-validate
go test for pdatatest

Documentation:

@sakulali sakulali requested a review from a team October 18, 2023 07:56
fatsheep9146
fatsheep9146 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@fatsheep9146 fatsheep9146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dmitryax dmitryax merged commit 51b8081 into open-telemetry:main Oct 19, 2023
84 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 19, 2023
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Oct 20, 2023
@sakulali @martin-majlis-s1
[pkg/pdatatest] Ignore trace ID for ptracetest (open-telemetry#27829)
0c6854c 
**Description:** 
Support ignore trace ID in span comparisons for ptracetest.

**Link to tracking Issue:**

open-telemetry#27687
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
@sakulali @sigilioso
[pkg/pdatatest] Ignore trace ID for ptracetest (open-telemetry#27829)
3406580 
**Description:** 
Support ignore trace ID in span comparisons for ptracetest.

**Link to tracking Issue:**

open-telemetry#27687
@sakulali sakulali deleted the fix-ptracetest-traceid branch November 2, 2023 13:57
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@sakulali @jmsnll
[pkg/pdatatest] Ignore trace ID for ptracetest (open-telemetry#27829)
24225e6 
**Description:** 
Support ignore trace ID in span comparisons for ptracetest.

**Link to tracking Issue:**

open-telemetry#27687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@fatsheep9146 fatsheep9146 fatsheep9146 approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@atoulme atoulme

Labels
pkg/pdatatest
Projects
None yet
Milestone
v0.88.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sakulali @atoulme @fatsheep9146 @dmitryax