Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Fix issue with named parameter spacing #28511

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Fixes an issue with the grammar where named parameters had to have a space after the =.

Link to tracking Issue:
Closes #27638

Testing:
Added a new unit test

pkg/ottl/grammar.go Outdated Show resolved Hide resolved
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work figuring this one out.

@evan-bradley evan-bradley merged commit 501ef10 into open-telemetry:main Oct 24, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 24, 2023
@TylerHelmuth TylerHelmuth deleted the ottl-fix-named-param-spacing branch October 24, 2023 14:17
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
**Description:** 
Fixes an issue with the grammar where named parameters had to have a
space after the `=`.

**Link to tracking Issue:**
Closes
open-telemetry#27638

**Testing:** 
Added a new unit test
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:** 
Fixes an issue with the grammar where named parameters had to have a
space after the `=`.

**Link to tracking Issue:**
Closes
open-telemetry#27638

**Testing:** 
Added a new unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] Parsing of named arguments is whitespace dependent
4 participants