Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double the number of processor build-and-test targets #32526

Merged
merged 5 commits into from
May 1, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 18, 2024

Description: Double the number of processor test groups so that new tests can be added, e.g., the new tests in
#31946

Testing: These changes were applied in #31946 and they appeared to help with spurious test timeouts.

Similar to #32496

@jmacd jmacd requested review from a team and songy23 April 18, 2024 17:50
Comment on lines +32 to +33
PROCESSOR_MODS_1 := $(shell find ./processor/[p-z]* $(FIND_MOD_ARGS) -exec $(TO_MOD_DIR) )
PROCESSOR_MODS := $(PROCESSOR_MODS_0) $(PROCESSOR_MODS_1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives an 12/11 breakdown.

@jmacd jmacd added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 18, 2024
@songy23 songy23 added ci-cd CI, CD, testing, build issues Run Windows Enable running windows test on a PR labels Apr 18, 2024
@songy23
Copy link
Member

songy23 commented Apr 19, 2024

Need a rebase

@jmacd
Copy link
Contributor Author

jmacd commented Apr 22, 2024

This will need a rebase again following #32496, which is ready to merge.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to wait on this until #32496 is merged.

@jmacd jmacd marked this pull request as draft April 22, 2024 16:59
…tor-contrib into jmacd/double_processor_groups
@jmacd jmacd marked this pull request as ready for review April 23, 2024 18:39
@jmacd jmacd added the ready to merge Code review completed; ready to merge by maintainers label Apr 24, 2024
@codeboten codeboten merged commit 36ffd33 into open-telemetry:main May 1, 2024
215 checks passed
@github-actions github-actions bot added this to the next release milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants