Add internal/otelarrow package for shared code between otelarrow exporter, receiver #33579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
changed the title
…tor-contrib into jmacd/internalarrow
moh-osman3
approved these changes
Jun 17, 2024
…tor-contrib into jmacd/internalarrow
jmacd
added a commit
to open-telemetry/otel-arrow
that referenced
this pull request
Jun 21, 2024
Same as open-telemetry/opentelemetry-collector-contrib#33688 but merging this code here will let me create and test a PR in that repository, whereas it will be messy to build off this work in the same repository. I expect this package to be deleted after open-telemetry/opentelemetry-collector-contrib#33688 and open-telemetry/opentelemetry-collector-contrib#33579 merged, as discussed in #225. Part of #227.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…tor-contrib into jmacd/internalarrow
|
Reviewers -- this is not stale. This PR is blocking future development and minor improvements of the otel-arrow components. This is also intended to avoid dependency skew between these packages (which depend on unstable collector APIs but reside in an external repository) before they begin to hold up releases in this repository. |
…collector-contrib into jmacd/internalarrow
…tor-contrib into jmacd/internalarrow
…collector-contrib into jmacd/internalarrow
mwear
approved these changes
Jul 16, 2024
…tor-contrib into jmacd/internalarrow
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
…collector-contrib into jmacd/internalarrow
…tor-contrib into jmacd/internalarrow
…tor-contrib into jmacd/internalarrow
evan-bradley
pushed a commit
that referenced
this pull request
Aug 6, 2024
…33688) **Description:** With utilities to encode and decode timeout in the syntax specified by gRPC. This will be used by the otelarrow components to encode and decode timeout values. In that sense, the new code could also be added into the pending internal/otelarrow package, see #33579 As this code is derived from gRPC-Go, some text is added in `NOTICE` according to the license. The code that this was derived from contained a TODO, which was largely addressed by eliminating very short timeouts from being encoded. This code will encode timeouts in milliseconds, seconds, hours, and days but it will not encode microsecond/nanosecond durations, these are rounded to `0m`. The decoder will handle all durations that gRPC specifies, so that this logic can change in the future. **Link to tracking Issue:** open-telemetry/otel-arrow#227 **Testing:** Adds basic tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The otelarrowexporter and otelarrowreceiver components depend on several libraries in the open-telemetry/otel-arrow repository, which would complicate release management in both repositories. This change eliminates the dependency on
otel-arrow/collectorby moving each of those packages into a subdirectory ofinternal/otelarrow.Link to tracking Issue: #33567
Testing: This brings new integration tests into this repository for the two otelarrow components.
Documentation: Each of the three non-test packages exposed here has a brief README.md explaining why it exists. Each of these could be useful to non-Arrow components if helpful.