[chore][receiver/kubeletstats] Introduce retry on test that rely on shared Informer sync #33685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
force-pushed
the
fix_k8s_informer_tests
branch
from
fcaa473
to
a72e0f6
Compare
| }, 10*time.Second, 100*time.Millisecond, | ||
| "metrics not collected") | ||
|
|
||
| md, err = r.Scrape(context.Background()) |
There was a problem hiding this comment.
Do we need this second scrape?
There was a problem hiding this comment.
👍🏽 not really. Removed.
ChrsMark
force-pushed
the
fix_k8s_informer_tests
branch
from
a72e0f6
to
220525c
Compare
…nformer sync Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
fix_k8s_informer_tests
branch
from
220525c
to
3843338
Compare
TylerHelmuth
approved these changes
Jun 28, 2024
TylerHelmuth
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a "retry" check on the test that relies on the shared node informer. This retry will ensure that the first valid scrape will be after the informer has been "triggered" to handle the node's addition.
Link to tracking Issue: Related to #33681.
Testing:
Documentation: