Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Skip TestMRUReset until #34252 is fixed #34362

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[chore] Skip TestMRUReset until #34252 is fixed #34362

merged 1 commit into from
Aug 1, 2024

Conversation

pjanotti
Copy link
Contributor

This is failing too much on Windows skipping the test until it is fixed.

@pjanotti pjanotti requested a review from jmacd as a code owner July 31, 2024 23:26
@pjanotti pjanotti requested review from a team and crobert-1 July 31, 2024 23:26
@github-actions github-actions bot requested a review from moh-osman3 July 31, 2024 23:26
@crobert-1 crobert-1 added Run Windows Enable running windows test on a PR ready to merge Code review completed; ready to merge by maintainers labels Jul 31, 2024
@crobert-1
Copy link
Member

Related: #34252

@dmitryax dmitryax merged commit 07a7efd into open-telemetry:main Aug 1, 2024
200 of 201 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 1, 2024
@pjanotti pjanotti deleted the skip-TestMRUReset-on-windows branch August 1, 2024 18:17
@axw
Copy link
Contributor

axw commented Aug 2, 2024

Should this be reverted, now that #34260 is merged?

@crobert-1 crobert-1 mentioned this pull request Aug 2, 2024
Merged
@crobert-1
Copy link
Member

Should this be reverted, now that #34260 is merged?

Thanks for calling this out @axw, I've opened #34391 to effectively revert this 👍

mx-psi pushed a commit that referenced this pull request Aug 6, 2024
@crobert-1
[chore][internal/otelarrow] Unskip test (#34391)
e982922 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This reverts
#34362
as
#34260
was merged to resolve the test. The flakiness should be resolved so we
no longer need to skip this test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3

Assignees

@bogdandrutu bogdandrutu

Labels
internal/otelarrow ready to merge Code review completed; ready to merge by maintainers Run Windows Enable running windows test on a PR
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pjanotti @crobert-1 @axw @dmitryax @bogdandrutu