[connector/servicegraph] Extract the getDimensionValue function as a common function.
#34908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
github-actions
bot
requested review from
Frapschen,
mapno,
marctc and
portertech
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
force-pushed
the
getDimensionValue
branch
from
975ea76
to
a39e4e1
Compare
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
mwear
reviewed
Aug 28, 2024
jpkrohling
reviewed
Aug 29, 2024
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
mwear
approved these changes
Aug 29, 2024
mapno
approved these changes
Aug 30, 2024
Frapschen
approved these changes
Sep 3, 2024
jpkrohling
approved these changes
Sep 6, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…a common function. (open-telemetry#34908) **Description:** refactoring getDimensionValue func as util func for spanmetricsconnector,servicegraphconnector,exceptionconnector common usage <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** open-telemetry#34627 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> --------- Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: refactoring getDimensionValue func as util func for spanmetricsconnector,servicegraphconnector,exceptionconnector common usage
Link to tracking Issue: #34627
Testing:
Documentation: