-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/kubeletstats] Add feature gate for cpu utilization metrics' deprecation #35139
base: main
Are you sure you want to change the base?
[receiver/kubeletstats] Add feature gate for cpu utilization metrics' deprecation #35139
Conversation
55270f1
to
34525a5
Compare
858405b
to
732836c
Compare
Users can use the following metrics instead: | ||
- `k8s.node.cpu.usage` | ||
- `k8s.pod.cpu.usage` | ||
- `container.cpu.usage` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe add a note that usage metrics are not utilization metrics. So it's not one to one replacement.
Something like:
Note: usage metrics show usage in terms of resources such as CPU / bytes, not percentage used.
Previous utilization metric values were computed incorrectly.
732836c
to
a699e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
… deprecation Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
a699e0b
to
211faf9
Compare
Description:
This PR adds a feature gate as discussed at #27885 (comment).
If the feature gate is enabled the
container.cpu.utilization
,k8s.pod.cpu.utilization
andk8s.node.cpu.utilization
metrics will be not be disabled being replaced by thecontainer.cpu.usage
,k8s.pod.cpu.usage
andk8s.node.cpu.usage
.Feature gate schedule
stable
.@TylerHelmuth @dmitryax let me know what you think about this approach.
Link to tracking Issue:
Testing:
Documentation:
How to test this
.cpu.usage
metrics are reported..cpu.utilization
metrics are reported.