Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/groupbytrace] ensure metric has unit #35221

Merged
merged 5 commits into from
Sep 17, 2024
Merged

[processor/groupbytrace] ensure metric has unit #35221

merged 5 commits into from
Sep 17, 2024

Conversation

codeboten
Copy link
Contributor

A missing unit will break validation when mdatagen is updated

@codeboten
[processor/groupbytrace] ensure metric has unit
c995fa1 
A missing unit will break validation when mdatagen is updated

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested a review from a team September 16, 2024 20:33
@codeboten
Copy link
Contributor Author

See CI run: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10891433587/job/30222472876?pr=35215

@github-actions github-actions bot added the processor/groupbytrace Group By Trace processor label Sep 16, 2024
@codeboten codeboten mentioned this pull request Sep 16, 2024
Merged
crobert-1
crobert-1 reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we'll need a changelog, but looks good other than that.

@codeboten
changelog
acc3d6a 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
Merge branch 'main' into codeboten/add-unit
801d2a3
@codeboten
update unit
93faf23 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
make generate
8c328e5 
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten merged commit 3f4dbf1 into open-telemetry:main Sep 17, 2024
155 of 156 checks passed
@codeboten codeboten deleted the codeboten/add-unit branch September 17, 2024 15:19
@github-actions github-actions bot added this to the next release milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@crobert-1 crobert-1 crobert-1 approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

Assignees

@songy23 songy23

Labels
processor/groupbytrace Group By Trace processor
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
4 participants
@codeboten @TylerHelmuth @crobert-1 @songy23