Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/spanmetrics] Resource attributes support #7075

Closed
wants to merge 65 commits into from
Closed

[processor/spanmetrics] Resource attributes support #7075

wants to merge 65 commits into from

Commits on Dec 13, 2021

  1. starts initial work on optional resource attributes config to span me… 

    …trics processor
    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f5553a1 View commit details
    Browse the repository at this point in the history

  2. adds test to check metric length when copying resources

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    f186407 View commit details
    Browse the repository at this point in the history

  3. adds changelog and fixes tests

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    3206a11 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into OBC-256-Resource-Attributes-Merge-Upstream

    @Tenaria
    Tenaria authored Dec 13, 2021
    Configuration menu
    Copy the full SHA
    3da4719 View commit details
    Browse the repository at this point in the history

  5. fix tests

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    945a6d1 View commit details
    Browse the repository at this point in the history

  6. remove empty new line

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    fc62eab View commit details
    Browse the repository at this point in the history

  7. updates changelog

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    07b5ad3 View commit details
    Browse the repository at this point in the history

  8. add accidentally removed comment back in

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    5782cb0 View commit details
    Browse the repository at this point in the history

  9. revert variable name change and fix comment

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    e2eb41d View commit details
    Browse the repository at this point in the history

  10. revert variable name cahnge

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    321c6e2 View commit details
    Browse the repository at this point in the history

  11. adds test to ensure ordering of keys used for aggregation

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    fb0561c View commit details
    Browse the repository at this point in the history

  12. fixes lock held; optimise for loop; add parallel in test; add comments

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    80ebf64 View commit details
    Browse the repository at this point in the history

  13. reverse conditions to simplify code

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    19775dc View commit details
    Browse the repository at this point in the history

  14. update tests to use defined constant instrumentationLibraryName

    @Tenaria
    Tenaria committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8c2d38e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Merge branch 'main' into OBC-256-Resource-Attributes-Merge-Upstream

    @chenzhihao
    chenzhihao committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    cbbf532 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. update the logic of method updateCallMetrics

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    91c8b7d View commit details
    Browse the repository at this point in the history

  2. fix tests

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    068a1bd View commit details
    Browse the repository at this point in the history

  3. add todos

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    18f20d0 View commit details
    Browse the repository at this point in the history

  4. add todos

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    4d370ad View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into OBC-256-Resource-Attributes-Merge-Upstream

    @chenzhihao
    chenzhihao authored Jan 5, 2022
    Configuration menu
    Copy the full SHA
    024a122 View commit details
    Browse the repository at this point in the history

  6. fix lint

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    7561f97 View commit details
    Browse the repository at this point in the history

  7. fix lint

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    62e892f View commit details
    Browse the repository at this point in the history

  8. remove resourceAttrList

    @chenzhihao
    chenzhihao committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    d8edfda View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2022

  1. Update "resource_attributes" 

    - Use LRU cache for the "resource_attributes".
- Add document/usage for the "resource_attributes" configuration.
    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d175a4e View commit details
    Browse the repository at this point in the history

  2. fix lint

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    608a083 View commit details
    Browse the repository at this point in the history

  3. remove duplicate p.resetExemplarData()

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a0519c0 View commit details
    Browse the repository at this point in the history

  4. refactor how processor reset after every ConsumeTraces process

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    9772056 View commit details
    Browse the repository at this point in the history

  5. move keybuilder to a package

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    ae17b37 View commit details
    Browse the repository at this point in the history

  6. update comments

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    8ea124c View commit details
    Browse the repository at this point in the history

  7. add copyright license

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    78c11f3 View commit details
    Browse the repository at this point in the history

  8. user defer for p.reset() so that downstream components can get data q… 

    …uicker.
    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    fbea55f View commit details
    Browse the repository at this point in the history

  9. gofmt

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    3d6b4c1 View commit details
    Browse the repository at this point in the history

  10. refactor how we use p.lock

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    fd42b76 View commit details
    Browse the repository at this point in the history

  11. gofmt

    @chenzhihao
    chenzhihao committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7ed4b1c View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. added a set of unit tests to cover the excessive concurrent usage

    @chenzhihao
    chenzhihao committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f676e46 View commit details
    Browse the repository at this point in the history

  2. change the usage of the lock to make sure the processor can only be e… 

    …xecuted serially
    @chenzhihao
    chenzhihao committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    4b71675 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into OBC-256-Resource-Attributes-Merge-Upstream

    @chenzhihao
    chenzhihao committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    494b483 View commit details
    Browse the repository at this point in the history

  4. add comments; lint

    @chenzhihao
    chenzhihao committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    38ebb2a View commit details
    Browse the repository at this point in the history

  5. clean up comments

    @chenzhihao
    chenzhihao committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    cb5c3ac View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. extract out consumeTraceCase for multiple tests

    @chenzhihao
    chenzhihao committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f3138ae View commit details
    Browse the repository at this point in the history

  2. empty commit to rerun test

    @chenzhihao
    chenzhihao committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    f7fdba6 View commit details
    Browse the repository at this point in the history

  3. Revert "extract out consumeTraceCase for multiple tests" 

    This reverts commit f3138ae.
    @chenzhihao
    chenzhihao committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    ed910fb View commit details
    Browse the repository at this point in the history

  4. add compile time assertion check

    @chenzhihao
    chenzhihao committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    0a209af View commit details
    Browse the repository at this point in the history

  5. remove dated comment

    @chenzhihao
    chenzhihao committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    17e35f1 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. make parameter vars consistent with naming

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    4c2cc13 View commit details
    Browse the repository at this point in the history

  2. rewording

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    662dab0 View commit details
    Browse the repository at this point in the history

  3. rename test function to camel case

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    442ab94 View commit details
    Browse the repository at this point in the history

  4. add comments for metricKey and resourceKey

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    40f7eae View commit details
    Browse the repository at this point in the history

  5. fix typos

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    529a623 View commit details
    Browse the repository at this point in the history

  6. iterate the slice via range

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    dd7609a View commit details
    Browse the repository at this point in the history

  7. simplify code

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    76713ee View commit details
    Browse the repository at this point in the history

  8. simplify code

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    21822be View commit details
    Browse the repository at this point in the history

  9. fix lint

    @chenzhihao
    chenzhihao committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5483b44 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. rename variable

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    4df2bb7 View commit details
    Browse the repository at this point in the history

  2. simplify code

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    d52bc55 View commit details
    Browse the repository at this point in the history

  3. simplify code

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    80a1dd2 View commit details
    Browse the repository at this point in the history

  4. add comments for keybuilder

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1a90bae View commit details
    Browse the repository at this point in the history

  5. update comment; remove defer()

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    62b1e9a View commit details
    Browse the repository at this point in the history

  6. treat empty string as valid

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    6b507da View commit details
    Browse the repository at this point in the history

  7. make Seperator public

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    f8f6112 View commit details
    Browse the repository at this point in the history

  8. add missed configuration field

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b840730 View commit details
    Browse the repository at this point in the history

  9. add test for BuildMetricKey() and BuildResourceAttrKey()

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    2f4034d View commit details
    Browse the repository at this point in the history

  10. fix typo; add comments to the testdata config files.

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    524509f View commit details
    Browse the repository at this point in the history

  11. gofmt

    @chenzhihao
    chenzhihao committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    828b674 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. service name is not mandatory as an attribute

    @chenzhihao
    chenzhihao committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    c8853c2 View commit details
    Browse the repository at this point in the history