Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently stabilized module breaks tooling #9827

Closed
djaglowski opened this issue Mar 25, 2024 · 4 comments · Fixed by open-telemetry/opentelemetry-go-build-tools#582
Closed
Assignees
Labels
priority:p1 High release release-retro Issues discussed in a release retrospective

Comments

@djaglowski
Copy link
Member

In this case, configcompression was recently marked stable. This causes failures when running make update-otel on contrib (step 1 of the release process).

@TylerHelmuth explained the situation well: configcompression has been moved from beta to stable but not had a release yet. The multimod tool sees it in the stable set, knows there was a 1.3.0 release, and tries to make the tag 1.3.1 for everything, but configcompression never had a 1.3.0. I was able to proceed my moving configcompression back to beta locally and then running make update-otel. It will generate a 0.96.1 tag for configcompression.

Also see open-telemetry/opentelemetry-collector-contrib#31778

@djaglowski djaglowski added release release-retro Issues discussed in a release retrospective labels Mar 25, 2024
@djaglowski djaglowski added release:blocker The issue must be resolved before cutting the next release priority:p1 High and removed release:blocker The issue must be resolved before cutting the next release labels Mar 25, 2024
@mx-psi
Copy link
Member

mx-psi commented Mar 26, 2024

Another thing to fix: we have not documented that we need to update this when stabilizing a module: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/9adb91e165fb90c22c0dab0e658bf04414bfcb7c/internal/buildscripts/modules#L36 We should add this to the release steps

@TylerHelmuth
Copy link
Member

Commenting that this came up again for release 0.104.0 when configretry was stabilized.

@mx-psi
Copy link
Member

mx-psi commented Jul 8, 2024

This will come up again in v0.105.0 because of configtls. I am looking into it, but it feels like we will need to fix this in multimod itself

@mx-psi
Copy link
Member

mx-psi commented Jul 9, 2024

I filed open-telemetry/opentelemetry-go-build-tools/pull/582 that I think should fix this, PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p1 High release release-retro Issues discussed in a release retrospective
Projects
None yet
3 participants