Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multimod] Resolve version for commit per module instead of per module set #582

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 9, 2024

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (78f03ee) to head (60ca64d).

Files Patch % Lines
multimod/internal/prerelease/prerelease.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   60.64%   60.74%   +0.09%     
==========================================
  Files          40       40              
  Lines        1964     1969       +5     
==========================================
+ Hits         1191     1196       +5     
  Misses        626      626              
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi marked this pull request as ready for review July 9, 2024 08:43
@mx-psi mx-psi requested review from a team and atoulme July 9, 2024 08:43
multimod/internal/common/tools.go Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented Jul 9, 2024

I tried this out on open-telemetry/opentelemetry-collector-contrib/pull/33977. It works correctly, although it is a bit slower at first and faster at the tidying stage (likely because the Go proxy is caching the version at an earlier stage). The overall time feels about the same.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mx-psi!

@mx-psi mx-psi merged commit af03a26 into open-telemetry:main Jul 9, 2024
12 checks passed
@mx-psi mx-psi deleted the mx-psi/multimod-modref branch July 9, 2024 15:55
@mx-psi mx-psi mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recently stabilized module breaks tooling
4 participants