Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp] Add NewDefaultCORSConfig function #10676

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 20, 2024

Description

Add NewDefaultCORSConfig function to initialize the default confighttp.CORSConfig

Link to tracking issue

#9655

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (b53f57d) to head (6014b63).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10676   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         403      403           
  Lines       18806    18808    +2     
=======================================
+ Hits        17323    17325    +2     
  Misses       1123     1123           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme
Copy link
Contributor Author

atoulme commented Jul 23, 2024

@andrzej-stencel please review?

@atoulme atoulme added the ready-to-merge Code review completed; ready to merge by maintainers label Aug 7, 2024
@mx-psi mx-psi merged commit 00d9d72 into open-telemetry:main Aug 8, 2024
67 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants