Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/builder] clarify mismatched versions in the warning message #10767

Merged

Conversation

terakoya76
Copy link
Contributor

@terakoya76 terakoya76 commented Jul 31, 2024

Description

Refine the warning message to make it useful for the end user.

Link to tracking issue

Fixes #10514

Testing

Locally tested.

2024-07-31T22:03:05.984+0900    INFO    internal/command.go:125 OpenTelemetry Collector Builder {"version": "(devel)"}
2024-07-31T22:03:05.984+0900    INFO    internal/command.go:136 Using default build configuration
2024-07-31T22:03:05.985+0900    INFO    builder/config.go:142   Using go        {"go-executable": "/usr/local/bin/go"}
2024-07-31T22:03:05.985+0900    INFO    builder/main.go:77      You're building a distribution with non-aligned version of the builder. The version mismatch may cause the compilation failure. It's recommended to use the same version.       {"collector-version": "0.104.0", "builder-version": "0.106.1"}
2024-07-31T22:03:05.985+0900    INFO    builder/main.go:100     Sources created {"path": "/tmp/otelcol-distribution3869530617"}
2024-07-31T22:03:06.510+0900    INFO    builder/main.go:191     Getting go modules
2024-07-31T22:03:06.552+0900    INFO    builder/main.go:111     Compiling
2024-07-31T22:03:07.080+0900    INFO    builder/main.go:130     Compiled        {"binary": "/tmp/otelcol-distribution3869530617/otelcorecol"}

Documentation

N/A

Note

I did not add a changelog entry because other PRs that only changed logging messages and behavior did not add it too.
If this is an incorrect understanding, please point it out.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (75fd259) to head (3d648e8).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10767      +/-   ##
==========================================
- Coverage   92.06%   91.36%   -0.70%     
==========================================
  Files         404      406       +2     
  Lines       18819    19007     +188     
==========================================
+ Hits        17325    17366      +41     
- Misses       1134     1283     +149     
+ Partials      360      358       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terakoya76 terakoya76 force-pushed the refine_ocb_version_mismatch_warning branch from 6bd86a2 to c9cdc6e Compare July 31, 2024 13:23
@terakoya76 terakoya76 marked this pull request as ready for review July 31, 2024 13:41
@terakoya76 terakoya76 requested review from a team and bogdandrutu July 31, 2024 13:41
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 7, 2024
@songy23 songy23 requested a review from codeboten August 7, 2024 20:30
@codeboten codeboten merged commit 291aa24 into open-telemetry:main Aug 8, 2024
37 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
@terakoya76 terakoya76 deleted the refine_ocb_version_mismatch_warning branch August 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useless warning about ocb version missmatch
4 participants