Fix processor metrics not being reported initially with 0 values #10857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After open-telemetry#10693, the processor helper only reports metrics if they got any values other than 0. As a user, I would always prefer seeing 0 data points reported for any data sent through a processor for otelcol_processor_dropped_spans and otelcol_processor_refused_spans metrics.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10857 +/- ##
=======================================
Coverage 91.64% 91.65%
=======================================
Files 406 406
Lines 19001 19023 +22
=======================================
+ Hits 17414 17436 +22
Misses 1227 1227
Partials 360 360 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts #10693, which had an unintentional behavior change that made the processor helper report metrics only if they got values other than
0.Fixes #10855