Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test funcs that load entire config to servicetest #4606

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

bogdandrutu
Copy link
Member

Updates #4605

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@bogdandrutu bogdandrutu requested review from a team and codeboten December 21, 2021 21:09
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #4606 (0560bce) into main (eb6f051) will decrease coverage by 0.03%.
The diff coverage is 57.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4606      +/-   ##
==========================================
- Coverage   90.75%   90.71%   -0.04%     
==========================================
  Files         178      179       +1     
  Lines       10563    10567       +4     
==========================================
  Hits         9586     9586              
- Misses        759      763       +4     
  Partials      218      218              
Impacted Files Coverage Δ
config/configtest/configtest.go 91.95% <0.00%> (+0.95%) ⬆️
service/servicetest/configprovider.go 64.70% <64.70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb6f051...0560bce. Read the comment docs.

Updates open-telemetry#4605

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit 7de98eb into open-telemetry:main Dec 21, 2021
@bogdandrutu bogdandrutu deleted the mvload branch December 21, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants