Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[configgrpc] Change Headers field type to have opaque values #6853

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Dec 23, 2022

Description:

Like #6637, but on configgrpc.

Link to tracking Issue: Fixes #6852

@mx-psi mx-psi requested review from a team and Aneurysm9 December 23, 2022 15:50
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 90.45% // Head: 90.45% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4badd8a) compared to base (4cf50d0).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4badd8a differs from pull request most recent head 421bd7b. Consider uploading reports for the commit 421bd7b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6853   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files         238      238           
  Lines       14325    14329    +4     
=======================================
+ Hits        12958    12962    +4     
  Misses       1102     1102           
  Partials      265      265           
Impacted Files Coverage Δ
config/configgrpc/configgrpc.go 91.47% <ø> (ø)
exporter/otlpexporter/factory.go 90.76% <100.00%> (ø)
exporter/otlpexporter/otlp.go 93.68% <100.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mx-psi
Copy link
Member Author

mx-psi commented Dec 23, 2022

Adding 'Skip contrib tests' as done in #6637, we'll have to fix the issues on the next update-otel PR

@mx-psi mx-psi added the ready-to-merge Code review completed; ready to merge by maintainers label Jan 20, 2023
@bogdandrutu bogdandrutu merged commit d97f1eb into open-telemetry:main Jan 20, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jan 23, 2023
…lemetry#6853)

* [configgrpc] Change Headers field type to have opaque values

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[configgrpc] Make Headers field opaque
3 participants