Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a simple example to use this client demo for AdService #102

Closed
laziobird opened this issue Jun 3, 2022 · 2 comments
Closed

Give a simple example to use this client demo for AdService #102

laziobird opened this issue Jun 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@laziobird
Copy link

laziobird commented Jun 3, 2022

Is your feature request related to a problem?

@mic-max @reyang

I found a client sample for this Java Project called "AdService" , and it is able to some steps for running , like this

  1. build a image for AdService , for example:
cd  /${project}/opentelemetry-demo-webstore/src/adservice
docker build -t  adservice:v1  . 
  1. run a instance for AdService by Docker, for example:
docker run -d -p 9555:9555 adservice:v1 
  1. enter into the docker instance and start a client demo, for example:
docker exec -it 3d6a8db7322a /bin/sh
sh /app/build/install/hipstershop/bin/AdServiceClient
  1. check if AdServer is successful to start by the log of this client , for example :
2022-06-03 17:57:11 - hipstershop.AdServiceClient - Get Ads with context camera ... trace_id= span_id= trace_flags= 
2022-06-03 17:57:12 - hipstershop.AdServiceClient - Ads: Hairdryer for sale. 50% off. trace_id= span_id= trace_flags= 
2022-06-03 17:57:12 - hipstershop.AdServiceClient - Ads: Bamboo glass jar for sale. 10% off. trace_id= span_id= trace_flags= 

Describe the solution you'd like:

So, i want to add more details for how to run a client and check the AdService . Maybe there ? https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/adservice/README.md

Describe alternatives you've considered.

A suggestion is just for more people to use this Java demo easily . What do you think? 😊

@laziobird laziobird added the enhancement New feature or request label Jun 3, 2022
@laziobird laziobird changed the title Give a simple example to use client for AdService Give a simple example to use this client demo for AdService Jun 3, 2022
@mic-max
Copy link
Contributor

mic-max commented Jun 3, 2022

That's great!!!

I think these instructions also belong in /src/adservice/README.md and also think we should still use the docker compose up command for running the service though to keep it simple and not give lots of ways to run these containers, especially if (not in this case) the service depends on another service or resource.

@julianocosta89
Copy link
Member

AdService client was removed as wasn't being used in the demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants