Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a simple example to use this client demo for AdService for issue #102 #113

Closed
wants to merge 9 commits into from

Conversation

laziobird
Copy link

Fixes #.
#102
Changes
Please provide a brief description of the changes here.
I found a client sample for this Java Project called "AdService", and it is able to some steps for running .

So, i start to add more details for how to run a client and check the AdService .

laziobird and others added 8 commits June 5, 2022 11:05
I found a client sample for this Java Project called "AdService" , and it is able to some steps for running . So, i want to add more details for how to run a client and check the  AdService.
@laziobird laziobird requested a review from a team as a code owner June 5, 2022 03:45
Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Tim, ya the instructions look good thanks! I was wondering if we could use docker compose build and docker compose up commands instead though, then the port will be loaded from the .env and then the client could also use that same variable

@cartersocha
Copy link
Contributor

What's the benefit of running the ad service locally?

@mic-max
Copy link
Contributor

mic-max commented Jun 14, 2022

sample for this Java Project called "AdService", and it is able to some steps for running .

So, i start to add more details for how to run a client and check the AdService

This PR is adding instructions to use the ad service's client that was included from the google repository.
It's used to make direct requests to the service without setting up the whole project.

We have other similar clients

@mic-max
Copy link
Contributor

mic-max commented Jun 14, 2022

@laziobird Could you please fix the blocking CI checks

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 22, 2022
@cartersocha
Copy link
Contributor

@laziobird could you update the branch & rerun the checks? We should be ready to merge if they pass

@laziobird laziobird closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants