-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added architecture information to repo. #124
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianocosta89
requested changes
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
All of the single and double quotes are of the "fancy" type |
mic-max
reviewed
Jun 9, 2022
mic-max
reviewed
Jun 9, 2022
mic-max
reviewed
Jun 9, 2022
mic-max
approved these changes
Jun 9, 2022
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
julianocosta89
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
GaryPWhite
pushed a commit
to wayfair-contribs/opentelemetry-demo
that referenced
this pull request
Jun 30, 2022
* add architecture markdown file * add architecture * add architecture * final link * fix links * Update Requirements/architecture-requirements.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Update Requirements/architecture-requirements.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Update Requirements/architecture-requirements.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * updated per PR comments Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* add architecture markdown file * add architecture * add architecture * final link * fix links * Update Requirements/architecture-requirements.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Update Requirements/architecture-requirements.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * Update Requirements/architecture-requirements.md Co-authored-by: Juliano Costa <julianocosta89@outlook.com> * updated per PR comments Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the architecture google doc into a markdown file. https://docs.google.com/document/d/1toQqAa4GApjFN3bvkEsq98Rb7WtbeKr3whsipAB3j1Q/edit
Tentatively placed it in the requirements folder but docs may be a better place.