Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added architecture information to repo. #124

Merged
merged 10 commits into from
Jun 10, 2022
Merged

Added architecture information to repo. #124

merged 10 commits into from
Jun 10, 2022

Conversation

cartersocha
Copy link
Contributor

Converted the architecture google doc into a markdown file. https://docs.google.com/document/d/1toQqAa4GApjFN3bvkEsq98Rb7WtbeKr3whsipAB3j1Q/edit

Tentatively placed it in the requirements folder but docs may be a better place.

@cartersocha cartersocha requested a review from a team as a code owner June 8, 2022 20:34
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

Requirements/architecture-requirements.md Outdated Show resolved Hide resolved
Requirements/architecture-requirements.md Show resolved Hide resolved
Requirements/architecture-requirements.md Outdated Show resolved Hide resolved
Requirements/architecture-requirements.md Outdated Show resolved Hide resolved
Requirements/architecture-requirements.md Show resolved Hide resolved
@mic-max
Copy link
Contributor

mic-max commented Jun 9, 2022

All of the single and double quotes are of the "fancy" type

cartersocha and others added 5 commits June 9, 2022 23:38
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@cartersocha cartersocha merged commit a49f3b8 into open-telemetry:main Jun 10, 2022
GaryPWhite pushed a commit to wayfair-contribs/opentelemetry-demo that referenced this pull request Jun 30, 2022
* add architecture markdown file

* add architecture

* add architecture

* final link

* fix links

* Update Requirements/architecture-requirements.md

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* Update Requirements/architecture-requirements.md

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* Update Requirements/architecture-requirements.md

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* updated per PR comments

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add architecture markdown file

* add architecture

* add architecture

* final link

* fix links

* Update Requirements/architecture-requirements.md

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* Update Requirements/architecture-requirements.md

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* Update Requirements/architecture-requirements.md

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>

* updated per PR comments

Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants