Delete /pb/ directory's README.md
#131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No necessary and currently gets copied unnecessarily in the `Dockerfile`s - that could be avoided by making the copy commands only copy all `*.pb` but I'm not sure how much explaining is needed for this file. Each service should explain in their own README files what types of requests they can receive and what their responses will look like and any outgoing requests too?
|
@mic-max would you update the PR title to clarify which README.md file being deleted? |
|
I guess @cartersocha added this intentionally so other markdown files can reference this folder by linking to README.md, @mic-max see if you can get the CI clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No necessary and currently gets copied unnecessarily in the
Dockerfiles - that could be avoided by making the copy commands only copy all*.pbbut I'm not sure how much explaining is needed for this file. Each service should explain in their own README files what types of requests they can receive and what their responses will look like and any outgoing requests too?