Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ad and cart service do not generate errors by default #1648

Closed
wants to merge 1 commit into from

Conversation

flands
Copy link
Contributor

@flands flands commented Jun 30, 2024

Changes

Addresses #1628 and adds variability to errors for cart service

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the [docs][]
  • Appropriate Helm chart updates in the [helm-charts][]

Addresses open-telemetry#1628 and adds variability to errors for cart service
@flands flands requested a review from a team as a code owner June 30, 2024 14:37
@github-actions github-actions bot added docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released labels Jun 30, 2024
@flands
Copy link
Contributor Author

flands commented Jun 30, 2024

Hmm, while this works, it generates an error: flagd | 2024-06-30T14:41:30.614Z error evaluator/fractional.go:30 parse fractional evaluation data: percentages must sum to 100, got: 110 {"component": "evaluator", "evaluator": "json"} will revisit this.

@flands flands closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-update-required Requires documentation update helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant