Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel-col] Add docker stats receiver #1650

Merged

Conversation

julianocosta89
Copy link
Member

@julianocosta89 julianocosta89 commented Jul 1, 2024

Changes

This PR adds the docker_stats receiver to the demo.
This receiver is meant to be used only when running locally on Docker.

For that to work we need privileged access to docker sock:

    user: 0:0
    volumes:
      - ${DOCKER_SOCK}:/var/run/docker.sock

I've also added Prometheus receiver to get internal Collector Metrics.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@julianocosta89 julianocosta89 requested a review from a team as a code owner July 1, 2024 21:25
@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label Jul 1, 2024
@julianocosta89 julianocosta89 changed the title Add docker stats receiver [otel-col] Add docker stats receiver Jul 1, 2024
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
julianocosta89 and others added 2 commits July 2, 2024 09:19
Co-authored-by: Roger Coll <roger.coll@elastic.co>
@julianocosta89 julianocosta89 removed helm-update-required Requires an update to the Helm chart when released labels Jul 2, 2024
@puckpuck
Copy link
Contributor

puckpuck commented Jul 2, 2024

This is a great change; it will lead to a few more things being needed, like Grafana dashboards and what we do about similar functionality in a K8s world. I'll create an issue so we can track the follow-up tasks.

@puckpuck puckpuck merged commit ebc32b9 into open-telemetry:main Jul 2, 2024
30 checks passed
@puckpuck puckpuck mentioned this pull request Jul 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants