Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shippingservice] set rpc.method and rpc.service #1690

Merged
merged 3 commits into from
Jul 31, 2024
Merged

[shippingservice] set rpc.method and rpc.service #1690

merged 3 commits into from
Jul 31, 2024

Conversation

mottibec
Copy link
Contributor

Changes

Added rpc.method and rpc.service to shippingservice grpc spans

@mottibec mottibec requested a review from a team as a code owner July 30, 2024 13:50
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 30, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@mottibec mottibec force-pushed the shipping-service-set-rpc-attrs branch from 1d44c6a to 883829f Compare July 30, 2024 13:54
puckpuck
puckpuck approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianocosta89 julianocosta89 merged commit b153ca6 into open-telemetry:main Jul 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puckpuck puckpuck puckpuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mottibec @puckpuck @julianocosta89