Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accountingservice container for non-root users #1696

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Jul 31, 2024

Changes

Currently, when you are using an user different than root to run the container, it fails because it has not permissions to run instrumentation.sh.
Fixes: #1692

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the [docs][]
  • Appropriate Helm chart updates in the [helm-charts][]

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested a review from a team as a code owner July 31, 2024 16:07
Copy link

github-actions bot commented Aug 9, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 9, 2024
Co-authored-by: Roger Coll <roger.coll@elastic.co>
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rogercoll
Copy link
Contributor

CI failure is unrelated to this PR (fix #1702)

@github-actions github-actions bot removed the Stale label Aug 10, 2024
@mviitane mviitane merged commit afa49c0 into open-telemetry:main Aug 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accountingservice container image fails as CreateContainerError when not running as root
4 participants