Update featureflagservice environment defaults #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature flag service won't start unless certain environment variables are set. For ease of set up, this provides default values. In the case of ports, these defaults match those in .env Perhaps in a future update the helm installation could automatically generate a secret to use for the `SECRET_KEY_BASE` variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature flag service won't start unless certain environment
variables are set. For ease of set up, this provides default
values. In the case of ports, these defaults match those
in .env
Perhaps in a future update the helm installation could automatically
generate a secret to use for the
SECRET_KEY_BASEvariable.When combined with open-telemetry/opentelemetry-helm-charts#344, fixes open-telemetry/opentelemetry-helm-charts#343