Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed quoteservice build from cache #369

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

saurabhdes
Copy link
Contributor

@saurabhdes saurabhdes commented Sep 16, 2022

Fixes #367

Changes

Adds cache-from section to quoteservice docker-compose file to resolve above issue.
Updates release to v0.4.0-alpha

Testing

Confirmed on my Local Mac that i am able to run all containers with docker compose up --no-build

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@saurabhdes saurabhdes requested a review from a team September 16, 2022 17:45
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@saurabhdes saurabhdes changed the title fixed quoteservice build from cache WIP: fixed quoteservice build from cache Sep 16, 2022
@saurabhdes saurabhdes marked this pull request as draft September 16, 2022 18:01
@saurabhdes
Copy link
Contributor Author

FYI - @julianocosta89 , i created this draft PR for the fix in quoteservice once the version is updated to 0.4.0. Or, if you plan to fix this issue as part of your PR to update repo to 0.4.0 that also works with me.

@cartersocha
Copy link
Contributor

Version is updated now or should be. Please sign the cla asap so we're not blocked on that later

@saurabhdes
Copy link
Contributor Author

thanks @cartersocha , i already signed the CLA , will work soon on updating the version as part of this PR.

@saurabhdes saurabhdes changed the title WIP: fixed quoteservice build from cache fixed quoteservice build from cache Sep 16, 2022
@saurabhdes saurabhdes marked this pull request as ready for review September 16, 2022 19:13
@saurabhdes
Copy link
Contributor Author

@cartersocha - I made the necessary changes, signed CLA and tested locally. Please let me know if there's anything else i need to do for this PR.

@cartersocha cartersocha merged commit 89f10c8 into open-telemetry:main Sep 16, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose up --no-build command fails with error on Mac
3 participants