Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add desired service map #48

Merged
merged 3 commits into from
May 25, 2022
Merged

Add desired service map #48

merged 3 commits into from
May 25, 2022

Conversation

austinlparker
Copy link
Member

Contributes to #30 -

  • Update service graph diagram with new + modified services
  • Add legend

@austinlparker austinlparker requested a review from a team as a code owner May 25, 2022 18:23
@reyang
Copy link
Member

reyang commented May 25, 2022

This looks cool @austinlparker 👍🥳

There is one issue with the coloring - legibility.

#29 (comment)

image

@austinlparker
Copy link
Member Author

Let me play with the text colors a bit to see what I can do.

docs/v1Graph.md Outdated Show resolved Hide resolved
@reyang
Copy link
Member

reyang commented May 25, 2022

Let me play with the text colors a bit to see what I can do.

Good luck! The tricky thing is to find the colors that work well for both light and dark themes.

@austinlparker
Copy link
Member Author

@reyang I tweaked the font colors a bit depending on the language color to improve legibility. I played around with a lot of other options first -- there's some limitations I ran into with the inline style support in mermaid classDef (for example, you can't use filter invert greyscale contrast tricks with CSS because you can't do an inline or escaped parentheses in classDefs?).

The actual colors of the languages are mapped 1:1 from the registry website colors.

@reyang
Copy link
Member

reyang commented May 25, 2022

@reyang I tweaked the font colors a bit depending on the language color to improve legibility. I played around with a lot of other options first -- there's some limitations I ran into with the inline style support in mermaid classDef (for example, you can't use filter invert greyscale contrast tricks with CSS because you can't do an inline or escaped parentheses in classDefs?).

The actual colors of the languages are mapped 1:1 from the registry website colors.

Looks fantastic!

@austinlparker austinlparker merged commit 5a38274 into open-telemetry:main May 25, 2022
@austinlparker austinlparker deleted the updateDocGraph branch May 25, 2022 20:35
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add updated graph

* tweak colors of fonts

* address review nit
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants