Recommendation Service Update - Python

compose.yml

@@ -141,11 +141,14 @@ services:
   # RecommendationService
   recommendationservice:
     build:
-      context: ./src/recommendationservice
+      context: ./
+      dockerfile: ./src/recommendationservice/Dockerfile
     ports:
-      - "${RECOMMENDATION_SERVICE_PORT}"
+      - "${RECOMMENDATION_SERVICE_PORT}:${RECOMMENDATION_SERVICE_PORT}"
+    depends_on:
+      - productcatalogservice
     environment:
-      - PORT=${RECOMMENDATION_SERVICE_PORT}
+      - RECOMMENDATION_SERVICE_PORT
       - PRODUCT_CATALOG_SERVICE_ADDR
       - OTEL_PYTHON_LOG_CORRELATION=true
       - OTEL_EXPORTER_OTLP_TRACES_ENDPOINT

src/recommendationservice/Dockerfile

@@ -14,29 +14,17 @@
 
 FROM python:3.10-slim
 
-# get packages
-COPY requirements.txt .
-RUN pip install -r requirements.txt
+WORKDIR /usr/src/app/
 
-# show python logs as they occur
-ENV PYTHONUNBUFFERED=0
+COPY ./src/recommendationservice/ ./
+COPY ./pb/ ./proto/
 
-RUN apt-get -qq update \
-    && apt-get install -y --no-install-recommends \
-    wget
-
-# download the grpc health probe
-RUN GRPC_HEALTH_PROBE_VERSION=v0.4.7 && \
-    wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \
-    chmod +x /bin/grpc_health_probe
-
-WORKDIR /recommendationservice
+RUN pip install --upgrade pip
+RUN pip install -r ./requirements.txt
 
 # add files into working directory
-COPY . .
-
-# set listen port
-ENV PORT "8080"
-EXPOSE 8080
+RUN python -m pip install grpcio-tools
+RUN python -m grpc_tools.protoc -I=./proto/ --python_out=./ --grpc_python_out=./ ./proto/demo.proto
 
-ENTRYPOINT ["opentelemetry-instrument", "python", "recommendation_server.py"]
+EXPOSE ${RECOMMENDATION_SERVICE_PORT}
+ENTRYPOINT [ "opentelemetry-instrument", "python", "recommendation_server.py" ]

src/recommendationservice/README.md

@@ -1,3 +1,23 @@
 # Read Me
 
-This is a placeholder
+To run the `./client.py` you must compile `/pb/demo.proto` into python code.
+
+```shell
+python -m grpc_tools.protoc -I./pb/ --python_out=./src/recommendationservice/ --grpc_python_out=./src/recommendationservice/ ./pb/demo.proto
+python ./src/recommendationservice/client.py
+```
+
+You should see output similar to the following
+
+```json
+{
+    "asctime": "2022-06-02 13:42:44,793",
+    "levelname": "INFO",
+    "name": "recommendationservice-server",
+    "filename": "client.py",
+    "lineno": 35,
+    "otelTraceID": "00000000000000000000000000000000",
+    "otelSpanID": "0000000000000000",
+    "message": "product_ids: \"6E92ZMYYFZ\"\nproduct_ids: \"OLJCESPC7Z\"\nproduct_ids: \"LS4PSXUNUM\"\nproduct_ids: \"2ZYFJ3GM2N\"\nproduct_ids: \"1YMWWN1N4O\"\n"
+}
+```

src/recommendationservice/client.py

@@ -14,7 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-import sys
 import grpc
 import demo_pb2
 import demo_pb2_grpc
@@ -24,18 +23,13 @@
 logger = getJSONLogger('recommendationservice-server')
 
 if __name__ == "__main__":
-    # get port
-    if len(sys.argv) > 1:
-        port = sys.argv[1]
-    else:
-        port = "8080"
-
     # set up server stub
-    channel = grpc.insecure_channel('localhost:'+port)
-
+    channel = grpc.insecure_channel('localhost:8080')
     stub = demo_pb2_grpc.RecommendationServiceStub(channel)
+
     # form request
     request = demo_pb2.ListRecommendationsRequest(user_id="test", product_ids=["test"])
+
     # make call to server
     response = stub.ListRecommendations(request)
     logger.info(response)