Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add_event macro to call otel_span:add_event/3 #145

Merged
merged 1 commit into from
Nov 15, 2020

Conversation

tsloughter
Copy link
Member

Fixes #144

@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #145 (e9576bc) into master (1d5a5a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   32.27%   32.27%           
=======================================
  Files          62       62           
  Lines        3145     3145           
=======================================
  Hits         1015     1015           
  Misses       2130     2130           
Flag Coverage Δ
api 50.22% <ø> (+0.22%) ⬆️
elixir 14.28% <ø> (ø)
erlang 32.13% <ø> (ø)
exporter 18.02% <ø> (ø)
sdk 66.88% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_batch_processor.erl 72.72% <0.00%> (-1.14%) ⬇️
apps/opentelemetry_api/src/otel_span.erl 68.42% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5a5a0...e9576bc. Read the comment docs.

@tsloughter tsloughter merged commit b5e6b65 into open-telemetry:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong module name for add_event(s) macro
3 participants