Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root span sampling #263

Merged
merged 10 commits into from
Aug 20, 2021
Merged

Fix root span sampling #263

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
28cfcc5
Fix root span sampling
dvic Aug 5, 2021
08e2b57
Add tests for root_span_sampling always_on and always_off
dvic Aug 6, 2021
92b592c
Remove comment in test code
dvic Aug 6, 2021
f3bf8a4
Add missing test case to all_testcases()
dvic Aug 6, 2021
3e2c2f1
Merge branch 'main' into dvic-root-span-sampling
dvic Aug 10, 2021
9a04b3f
Merge branch 'main' into dvic-root-span-sampling
tsloughter Aug 10, 2021
0f732f7
Merge branch 'main' into dvic-root-span-sampling
tsloughter Aug 11, 2021
18121ed
Merge branch 'main' into dvic-root-span-sampling
tsloughter Aug 19, 2021
7862aa5
Update for refactored otel_sampler:new function
dvic Aug 19, 2021
38b964c
Merge branch 'main' into dvic-root-span-sampling
tsloughter Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into dvic-root-span-sampling
  • Loading branch information
@tsloughter
tsloughter committed Aug 19, 2021
commit 38b964c0e24ad75d4cc24b0bbdf87b1b968ceb34
6 changes: 3 additions & 3 deletions apps/opentelemetry/test/opentelemetry_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ all() ->
all_testcases() ->
[disable_auto_registration, registered_tracers, with_span, macros, child_spans,
update_span_data, tracer_instrumentation_library, tracer_previous_ctx, stop_temporary_app,
reset_after, attach_ctx, default_sampler, root_span_sampling_always_on,
root_span_sampling_always_off,record_but_not_sample, record_exception_works,
record_exception_with_message_works].
reset_after, attach_ctx, default_sampler, non_recording_ets_table,
root_span_sampling_always_on, root_span_sampling_always_off,
record_but_not_sample, record_exception_works, record_exception_with_message_works].

groups() ->
[{w3c, [], [propagation]},
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.